Content: Slate Blackcurrant Watermelon Strawberry Orange Banana Apple Emerald Chocolate Marble
Background: Slate Blackcurrant Watermelon Strawberry Orange Banana Apple Emerald Chocolate Marble
Pattern: Blank Waves Notes Sharp Wood Rockface Leather Honey Vertical Triangles
Welcome to TerraFirmaCraft Forums

Register now to gain access to all of our features. Once registered and logged in, you will be able to contribute to this site by submitting your own content or replying to existing content. You'll be able to customize your profile, receive reputation points as a reward for submitting content, while also communicating with other members via your own private inbox, plus much more! This message will be removed once you have signed in.

  • Announcements

    • Dries007

      ATTENTION Forum Database Breach   03/04/2019

      There has been a breach of our database. Please make sure you change your password (use a password manager, like Lastpass).
      If you used this password anywhere else, change that too! The passwords themselves are stored hashed, but may old accounts still had old, insecure (by today's standards) hashes from back when they where created. This means they can be "cracked" more easily. Other leaked information includes: email, IP, account name.
      I'm trying my best to find out more and keep everyone up to date. Discord (http://invite.gg/TerraFirmaCraft) is the best option for up to date news and questions. I'm sorry for this, but the damage has been done. All I can do is try to make sure it doesn't happen again.
    • Claycorp

      This forum is now READ ONLY!   01/20/2020

      As of this post and forever into the future this forum has been put into READ ONLY MODE. There will be no new posts! A replacement is coming SoonTM . If you wish to stay up-to-date on whats going on or post your content. Please use the Discord or Sub-Reddit until the new forums are running.

      Any questions or comments can be directed to Claycorp on either platform.
Two

[Intentional][79.3] Sluice stops working after some time

12 posts in this topic

I built a standard sluice system with 3 sluices in place. I added water then gravel and all 3 sluices began working and produced output. A few minutes later however they stopped working, consuming gravel and producing items, however the working indication arrow still moves from left to right.

I gave them some time to check if it was a visual issue, but neither did produce any further items nor consume gravel within the next 10 minutes. I also tried to deconstruct and replace them, however they are still not working.

My guess is that they reached the same chunk limit as the pan. If that is the intended behavior then there should be some form of indication for that.

Edit: They also stop working permanently when the chunk they are placed in is unloaded. But in this case the progress arrow stops moving as well.

0

Share this post


Link to post
Share on other sites

Try throwing some soil into the unloaded sluice. It's much more likely that the interface simply froze, but the sluice continued processing and adding in more soil will update it.

0

Share this post


Link to post
Share on other sites

In case 1 the interface is not frozen as the arrow indicator is still working. It shows 50/50 as amount and the sluice is not accepting any more gravel. However as I wrote even after 10 minutes it was still in the same state.

0

Share this post


Link to post
Share on other sites

I said "into the unloaded sluice" which means I was talking about case 2. I still need to look a bit more into the sluice, but its very likely that yes a gold-pan like cap was added to them, and that we need to add some sort of indicator.

0

Share this post


Link to post
Share on other sites

After some further testing: yes the sluice in case 2 restarts working if you feed it again, my bad. Still wondering why this bug is in since like forever. Sometimes I really wish TFC would be open source so I can have a look. ;)

0

Share this post


Link to post
Share on other sites

After some further testing: yes the sluice in case 2 restarts working if you feed it again, my bad. Still wondering why this bug is in since like forever. Sometimes I really wish TFC would be open source so I can have a look. ;)

TFC is open source. In the case of persisting sluice bugs. I've not had the desire to do a ground up rewrite which is what they really need. So some bugs are bound to persist across builds.

0

Share this post


Link to post
Share on other sites

After some further testing: yes the sluice in case 2 restarts working if you feed it again, my bad. Still wondering why this bug is in since like forever. Sometimes I really wish TFC would be open source so I can have a look. ;)

Browse to your heart's content: https://github.com/Deadrik/TFCraft

0

Share this post


Link to post
Share on other sites

All fixes for all bugs incoming in a few seconds... ;)

0

Share this post


Link to post
Share on other sites

Please stop using the winky face. I realize you probably don't intend for it to be interpreted this way, but I'm getting reports of you being overly condescending because of it, and it kinda makes you look like a dick.

0

Share this post


Link to post
Share on other sites

In TESluice.java:298

if(cd.sluicedAmount > 300)
This is what causes the sluice to stop working once the chunk has been worked too much. I can't see any point where this is reset, so I guess that a chunk once overworked will be overworked forever.Before this line the progress is updated, that is why the indicator continues to work even though the sluice won't do anything anymore.If a sluice is supposed to overwork a chunk, this check should be moved to line 285 (if(soilAmount > 0 && waterInput && waterOutput)), otherwise the check and the block associated with it should be removed.I can't seem to get the sources to run as something is corrupted in my setup, so I could not test that. 

Please stop using the winky face. I realize you probably don't intend for it to be interpreted this way, but I'm getting reports of you being overly condescending because of it, and it kinda makes you look like a dick.

I think that is a misunderstanding as of some cultural differences. Around here it is a common joke, but I am sorry if I offended anyone.
0

Share this post


Link to post
Share on other sites

You are correct in that overworking a sluice, or a gold pan for that matter, is permanent; and this was an intentional decision.

 

I'll look into moving the check for a later hotfix if you don't manage to submit a PR for it before then.

0

Share this post


Link to post
Share on other sites

Added an overworked indicator to sluices for the next version. Placing a sluice in an overworked chunk won't say anything special, but as soon as you add soil to a sluice in an overworked chunk, the sluice will lock down so that it says "Overworked" instead of the soil amount, the arrow will stop moving, and the sluice will stop accepting gravel and sand blocks thrown at it.

0

Share this post


Link to post
Share on other sites