Content: Slate Blackcurrant Watermelon Strawberry Orange Banana Apple Emerald Chocolate Marble
Background: Slate Blackcurrant Watermelon Strawberry Orange Banana Apple Emerald Chocolate Marble
Pattern: Blank Waves Notes Sharp Wood Rockface Leather Honey Vertical Triangles
Welcome to TerraFirmaCraft Forums

Register now to gain access to all of our features. Once registered and logged in, you will be able to contribute to this site by submitting your own content or replying to existing content. You'll be able to customize your profile, receive reputation points as a reward for submitting content, while also communicating with other members via your own private inbox, plus much more! This message will be removed once you have signed in.

  • Announcements

    • Dries007

      ATTENTION Forum Database Breach   03/04/2019

      There has been a breach of our database. Please make sure you change your password (use a password manager, like Lastpass).
      If you used this password anywhere else, change that too! The passwords themselves are stored hashed, but may old accounts still had old, insecure (by today's standards) hashes from back when they where created. This means they can be "cracked" more easily. Other leaked information includes: email, IP, account name.
      I'm trying my best to find out more and keep everyone up to date. Discord (http://invite.gg/TerraFirmaCraft) is the best option for up to date news and questions. I'm sorry for this, but the damage has been done. All I can do is try to make sure it doesn't happen again.
    • Claycorp

      This forum is now READ ONLY!   01/20/2020

      As of this post and forever into the future this forum has been put into READ ONLY MODE. There will be no new posts! A replacement is coming SoonTM . If you wish to stay up-to-date on whats going on or post your content. Please use the Discord or Sub-Reddit until the new forums are running.

      Any questions or comments can be directed to Claycorp on either platform.
Maga

[Solved] Low Charcoal Production

8 posts in this topic

I have been feeling that the charcoal output from my log pits hasn't been very good lately. I did a test just now and my 8x8x4 charcoal pit (every pile full, meaning 4096 logs) only gave me 788 charcoal (ratio of ~5.2 logs per charcoal) Is this the intended number? 

 

I also noticed 3 spots where the 4-high log piles created 0 charcoal and this has me confused. Anyone else seeing this?

0

Share this post


Link to post
Share on other sites

Adding in the code for reference here:

int count = te.getNumberOfLogs();te.clearContents();float percent = 25 + worldObj.rand.nextInt(25);count = (int) (count * (percent / 100));worldObj.setBlock(x, y, z, TFCBlocks.Charcoal, count, 0x2);

So the way that charcoal pits should be working, is that each individual log pile creates its own charcoal block where it is, and then all the charcoal condenses down into the neat little pile.

 

So let's start with a full log pile (16 logs). In the first line, count will be set to 16. The second line clears out all of the logs in the log pile. The third line calculates the percent of coal that you are going to get per log, ranging from 25 to 49%. Worst case scenario for line 4 would be 25%, so (16 * (25/100)), which equals 4. Best case scenario of 49% would result in (16 * (49/100)), which equals 7.84. However, this value is cast to an integer, which is done through truncation, and not rounding, so we get 7. Finally, we create a charcoal block where the log pile was, with the count number of charcoal in it.

 

So if we start with an 8x8x4 charcoal pit (256 blocks) that is truly full, in theory you will get 256*4 (1024) to 256*7 (1792) charcoal. This leads us to one of two conclusions:

  • There is a bug in the code, and either the charcoal is not being created correctly, or something is happening when the charcoal blocks collapse onto each other to create the piles.
  • Something was miscounted, either the number of logs you used, or the charcoal you actually ended up with, as a yield of 788 charcoal means there was at maximum 3,152 logs in your pit.
0

Share this post


Link to post
Share on other sites

After creating a pit of my own encased in glass, I think I've found the problem, which also explains your 3 areas of no charcoal. Not all of the log piles update at exactly the same time and turn to charcoal, which means that the remaining log piles are setting their neighboring charcoal blocks on fire, which destroys them if they burn long enough.

0

Share this post


Link to post
Share on other sites

Interesting, I'll do some tests and look for the best workaround in charcoal pit layout. I hope this is something that can be coded out without too much trouble.

0

Share this post


Link to post
Share on other sites

Found the problem, and it's fixed for the next version. Multiple tests all confirmed at least 25% yields.

0

Share this post


Link to post
Share on other sites

Ah so there was a bug. I do remember noticing missing charcoal blocks in my charcoal pit much, much earlier on. Therefore, I resorted to a 3x3x3 charcoal room, dug out from a mountain, from which i get about 2 stacks of charcoal close to the minimum amount expected. Maybe in this set up, log piles don't easily catch on fire...?

0

Share this post


Link to post
Share on other sites

Sorry for my English.
If I put 16 logs in the pit the size of 1 block, I will receive an average of half.
in a coal pit the size of 1 block is not 16 logs, but only 1 and I get 1 unit of charcoal 100%. Is this a bug?

Edited by squirrel
0

Share this post


Link to post
Share on other sites

Just started getting this error today. After a new crashed hit my friend and I two games in a row. Can I get a refund or something? I cant even play this game online now.

0

Share this post


Link to post
Share on other sites