Content: Slate Blackcurrant Watermelon Strawberry Orange Banana Apple Emerald Chocolate Marble
Background: Slate Blackcurrant Watermelon Strawberry Orange Banana Apple Emerald Chocolate Marble
Pattern: Blank Waves Notes Sharp Wood Rockface Leather Honey Vertical Triangles
Welcome to TerraFirmaCraft Forums

Register now to gain access to all of our features. Once registered and logged in, you will be able to contribute to this site by submitting your own content or replying to existing content. You'll be able to customize your profile, receive reputation points as a reward for submitting content, while also communicating with other members via your own private inbox, plus much more! This message will be removed once you have signed in.

  • Announcements

    • Dries007

      ATTENTION Forum Database Breach   03/04/2019

      There has been a breach of our database. Please make sure you change your password (use a password manager, like Lastpass).
      If you used this password anywhere else, change that too! The passwords themselves are stored hashed, but may old accounts still had old, insecure (by today's standards) hashes from back when they where created. This means they can be "cracked" more easily. Other leaked information includes: email, IP, account name.
      I'm trying my best to find out more and keep everyone up to date. Discord (http://invite.gg/TerraFirmaCraft) is the best option for up to date news and questions. I'm sorry for this, but the damage has been done. All I can do is try to make sure it doesn't happen again.
    • Claycorp

      This forum is now READ ONLY!   01/20/2020

      As of this post and forever into the future this forum has been put into READ ONLY MODE. There will be no new posts! A replacement is coming SoonTM . If you wish to stay up-to-date on whats going on or post your content. Please use the Discord or Sub-Reddit until the new forums are running.

      Any questions or comments can be directed to Claycorp on either platform.
Ziusudra

[Solved] inconsistent requirements for blocks around forge

8 posts in this topic

This post has been automatically generated from a form submission.

Have you read, understood, and followed all of the rules listed in the blue box at the top of this form?: Yes
Topic Title: inconsistent requirements for blocks around forge
TFC Version #: 0.79.28.908
Forge Version #: 10.13.4.1558
SSP/SMP: Single Player
Have you deleted your config files or are using default configs and are still able to reproduce this bug?: Yes
Changed Config Options:
Do you have any mods other than Forge and TFC installed?: No
Other Mods Installed:
If you have Optifine or Cauldron installed, can you still reproduce the bug after uninstalling them?: I do not have Optifine or Cauldron installed.
Crash Report:
Description: It is possible to create a forge that then gets deleted after a block update. The parts of the code that require certain blocks around a forge block are not the same. ItemFlintSteel.java just requires rock with solid faces; ItemFirestarter.java also requires the block below be a NormalCube; and BlockForge.java requires that all 5 blocks be NormalCubes. Detailed blocks can be rock with solid faces but not NormalCubes.

 

EDIT NOTE (Hubertus): Changed the answer to question 1 from 'no', to 'yes', as per the poster's indication

0

Share this post


Link to post
Share on other sites

I came along and changed that no to a yes for you, since it seems like you made a mistake with the form! Let us know if you notice any other errors!

0

Share this post


Link to post
Share on other sites

I can make it so that it's consistent in all three classes, but it's still not going to work 100% as expected. For example, stairs don't have solid sides so you won't be able to use stair mode on blocks around your forge. The slab solid side check isn't properly implemented either, so you could chisel down the block and actually expose pretty much all of the side of the floor block. And the trigger of converting a stone block into a detailed block is still going to remove the forge because for that split second during the conversion the block isn't considered solid. You could  put the forge back though and further block updates wouldn't remove it.

0

Share this post


Link to post
Share on other sites

Sadly, further block updates will remove the forge. I only noticed the issue when I placed (or removed) a crucible on an existing forge that had a detailed block on one side. (Specifically, shale brick that was detailed before the forge was made. It is in fact detailed in a vanilla stair shape.)

I should have mentioned that before, sorry.

0

Share this post


Link to post
Share on other sites

Sorry if I confused you. My above statements are about what would happen if I changed the code. I understand that block updates currently remove the forge. What I'm saying is that even if I fix it, there are still going to be some specific block updates that still remove it.

0

Share this post


Link to post
Share on other sites

I'll go ahead and make the change so that it's consistent. Just realize it's still not going to behave the way you expect it to because there's much larger problems here than just the inconsistent check in those three classes.

0

Share this post


Link to post
Share on other sites