Content: Slate Blackcurrant Watermelon Strawberry Orange Banana Apple Emerald Chocolate Marble
Background: Slate Blackcurrant Watermelon Strawberry Orange Banana Apple Emerald Chocolate Marble
Pattern: Blank Waves Notes Sharp Wood Rockface Leather Honey Vertical Triangles
Welcome to TerraFirmaCraft Forums

Register now to gain access to all of our features. Once registered and logged in, you will be able to contribute to this site by submitting your own content or replying to existing content. You'll be able to customize your profile, receive reputation points as a reward for submitting content, while also communicating with other members via your own private inbox, plus much more! This message will be removed once you have signed in.

  • Announcements

    • Dries007

      Server Move   09/13/18

      I (Dries007) have recently taken over as main developer and server admin. This involved moving servers to reduce cost. It's likely there will be some more downtime in the future but most  things should be sorted by now. This forum is in dire need of replacement as the software is quite old and can't be easily updated. If you wish to discuss or stay updated, join our discord: https://invite.gg/terrafirmacraft. The forum will remain available to read, but will be locked in the future, when a new system is setup. The forum and wiki are now ad free. If you'd like to contribute to keeping it that way, you can do so via paypal or patreon.
M'cota

Bug in the scanLogs function for ItemStack null

3 posts in this topic

This post has been automatically generated from a form submission.

Have you read, understood, and followed all of the rules listed in the blue box at the top of this form?: Yes
Topic Title: Bug in the scanLogs function for ItemStack null
TFC Version #: 0.79.29
Forge Version #: 10.13.4..1558
SSP/SMP: Single Player
Have you deleted your config files or are using default configs and are still able to reproduce this bug?: Yes
Changed Config Options:
Do you have any mods other than Forge and TFC installed?: Yes
Other Mods Installed: NEI, IndustrialCraft 2, WAILA, Code Chicken Core
If you have Optifine or a non-forge server plugin api (Examples: Bukkit, Cauldron, Thermos, etc) installed, can you still reproduce the bug after uninstalling them?: I do not have Optifine or a non-forge server plugin api installed.
Crash Report:
Description: There is a discrepancy in the code for scanLogs where passing a null ItemStack (called from onBlockDestroyedByExplosion) calls world.setBlockToAir(i, j, k); instead of world.setBlock(i + x, j + y, k + z, Blocks.air, 0, 0x2); which seems to cause only the bottom block of the tree to be removed when the tree is destroyed by an explosion. I'm using the source code from https://github.com/Deadrik/TFCraft. I assume it is the latest version, I can only see 0.79.29 in the version number.

0

Share this post


Link to post
Share on other sites

I replaced the method called for ItemStack == null with the one called in ItemStack != null, and confirmed that it removes the entire tree and not just the bottom block.

scanLogs.JPG

0

Share this post


Link to post
Share on other sites

FYI TFC is no longer being maintained, development has moved to TFC2. As no game breaking bugs have been found in more than a year, it is unlikely it will be updated again. 

0

Share this post


Link to post
Share on other sites

Please sign in to comment

You will be able to leave a comment after signing in



Sign In Now