Content: Slate Blackcurrant Watermelon Strawberry Orange Banana Apple Emerald Chocolate Marble
Background: Slate Blackcurrant Watermelon Strawberry Orange Banana Apple Emerald Chocolate Marble
Pattern: Blank Waves Notes Sharp Wood Rockface Leather Honey Vertical Triangles
Welcome to TerraFirmaCraft Forums

Register now to gain access to all of our features. Once registered and logged in, you will be able to contribute to this site by submitting your own content or replying to existing content. You'll be able to customize your profile, receive reputation points as a reward for submitting content, while also communicating with other members via your own private inbox, plus much more! This message will be removed once you have signed in.

  • Announcements

    • Dries007

      ATTENTION Forum Database Breach   03/04/2019

      There has been a breach of our database. Please make sure you change your password (use a password manager, like Lastpass).
      If you used this password anywhere else, change that too! The passwords themselves are stored hashed, but may old accounts still had old, insecure (by today's standards) hashes from back when they where created. This means they can be "cracked" more easily. Other leaked information includes: email, IP, account name.
      I'm trying my best to find out more and keep everyone up to date. Discord (http://invite.gg/TerraFirmaCraft) is the best option for up to date news and questions. I'm sorry for this, but the damage has been done. All I can do is try to make sure it doesn't happen again.
    • Claycorp

      This forum is now READ ONLY!   01/20/2020

      As of this post and forever into the future this forum has been put into READ ONLY MODE. There will be no new posts! A replacement is coming SoonTM . If you wish to stay up-to-date on whats going on or post your content. Please use the Discord or Sub-Reddit until the new forums are running.

      Any questions or comments can be directed to Claycorp on either platform.
M'cota

Bug in the scanLogs function for ItemStack null

3 posts in this topic

This post has been automatically generated from a form submission.

Have you read, understood, and followed all of the rules listed in the blue box at the top of this form?: Yes
Topic Title: Bug in the scanLogs function for ItemStack null
TFC Version #: 0.79.29
Forge Version #: 10.13.4..1558
SSP/SMP: Single Player
Have you deleted your config files or are using default configs and are still able to reproduce this bug?: Yes
Changed Config Options:
Do you have any mods other than Forge and TFC installed?: Yes
Other Mods Installed: NEI, IndustrialCraft 2, WAILA, Code Chicken Core
If you have Optifine or a non-forge server plugin api (Examples: Bukkit, Cauldron, Thermos, etc) installed, can you still reproduce the bug after uninstalling them?: I do not have Optifine or a non-forge server plugin api installed.
Crash Report:
Description: There is a discrepancy in the code for scanLogs where passing a null ItemStack (called from onBlockDestroyedByExplosion) calls world.setBlockToAir(i, j, k); instead of world.setBlock(i + x, j + y, k + z, Blocks.air, 0, 0x2); which seems to cause only the bottom block of the tree to be removed when the tree is destroyed by an explosion. I'm using the source code from https://github.com/Deadrik/TFCraft. I assume it is the latest version, I can only see 0.79.29 in the version number.

0

Share this post


Link to post
Share on other sites

I replaced the method called for ItemStack == null with the one called in ItemStack != null, and confirmed that it removes the entire tree and not just the bottom block.

scanLogs.JPG

0

Share this post


Link to post
Share on other sites

FYI TFC is no longer being maintained, development has moved to TFC2. As no game breaking bugs have been found in more than a year, it is unlikely it will be updated again. 

0

Share this post


Link to post
Share on other sites