Content: Slate Blackcurrant Watermelon Strawberry Orange Banana Apple Emerald Chocolate Marble
Background: Slate Blackcurrant Watermelon Strawberry Orange Banana Apple Emerald Chocolate Marble
Pattern: Blank Waves Notes Sharp Wood Rockface Leather Honey Vertical Triangles
Welcome to TerraFirmaCraft Forums

Register now to gain access to all of our features. Once registered and logged in, you will be able to contribute to this site by submitting your own content or replying to existing content. You'll be able to customize your profile, receive reputation points as a reward for submitting content, while also communicating with other members via your own private inbox, plus much more! This message will be removed once you have signed in.

  • Announcements

    • Dries007

      ATTENTION Forum Database Breach   03/04/2019

      There has been a breach of our database. Please make sure you change your password (use a password manager, like Lastpass).
      If you used this password anywhere else, change that too! The passwords themselves are stored hashed, but may old accounts still had old, insecure (by today's standards) hashes from back when they where created. This means they can be "cracked" more easily. Other leaked information includes: email, IP, account name.
      I'm trying my best to find out more and keep everyone up to date. Discord (http://invite.gg/TerraFirmaCraft) is the best option for up to date news and questions. I'm sorry for this, but the damage has been done. All I can do is try to make sure it doesn't happen again.
    • Claycorp

      This forum is now READ ONLY!   01/20/2020

      As of this post and forever into the future this forum has been put into READ ONLY MODE. There will be no new posts! A replacement is coming SoonTM . If you wish to stay up-to-date on whats going on or post your content. Please use the Discord or Sub-Reddit until the new forums are running.

      Any questions or comments can be directed to Claycorp on either platform.
mcfrei

[Solved][minor] increasing saplingTimerMultiplier makes saplings grow for 600+ days in worlds where some time has passed already

3 posts in this topic

TFC Version #: 0.79.17 Forge Version #: 10.13.2.1291 SSP/SMP (SinglePlayer/MultiPlayer): SMP Description:  Very long growth time for saplings, if you increase the sapling timer multiplier. I believe that the error is in the line 118 of BlockSapling.java, where TFCOptions.saplingTimerMultiplier is multiplied at TFC_Time.getTotalTicks() because the parenthesis is put at the start, and not after getTotalTicks().

 

I have read the rules for posting and official bug list, and i couldn't find it. I beleive it's a one-line quick fix, and i couldn't find anything that forbids the suggestions to fix it. I can make a pull-request if it is allowed and applicable, and feel free to delete this post if it violates any forum rules.Have you deleted your config files or are using default configs and are still able to reproduce this bug? (Yes/No): Yes, but you have to wait to see it Do you have any mods other than Forge and TFC installed? (Yes/No): YesIf yes, which mods? NEI + TFC NEI, WAILA + TFC WAILA, FastCraft, Optifine, Decorations, BiblioCraft + BiblioWoods If you have Optifine or Cauldron installed, can you still reproduce the bug after uninstalling them? (Yes/No): Yes

Edited by mcfrei
0

Share this post


Link to post
Share on other sites

If you know how to fix then submit a PR on the repo.

0

Share this post


Link to post
Share on other sites

What value did you change the sapling multiplier to? Which sapling did you test, and how did you know it resulted in a 600 day growth time?

 

If you used WAILA, could you please provide a screenshot, in combination with a pastebin of your TFCOptions.cfg file?

 

It's important to note that sapling growth time is not completely dependent on that timer. Just because the time has passed, doesn't mean the sapling will automatically grow. So doing /time add commands is not an effective way to see how long until the sapling grows, because that doesn't simulate all the random ticks that blocks get during that time period.

 

Also realize that editing the config file on an existing world will not update the timer on every single sapling in the world. That timer is only determined when the sapling is initially planted, and from there it simply counts down. So any config changes to existing worlds will only affect saplings planted after that change.

 

I see what you mean, fixed for 79.18

0

Share this post


Link to post
Share on other sites