Content: Slate Blackcurrant Watermelon Strawberry Orange Banana Apple Emerald Chocolate Marble
Background: Slate Blackcurrant Watermelon Strawberry Orange Banana Apple Emerald Chocolate Marble
Pattern: Blank Waves Notes Sharp Wood Rockface Leather Honey Vertical Triangles
Welcome to TerraFirmaCraft Forums

Register now to gain access to all of our features. Once registered and logged in, you will be able to contribute to this site by submitting your own content or replying to existing content. You'll be able to customize your profile, receive reputation points as a reward for submitting content, while also communicating with other members via your own private inbox, plus much more! This message will be removed once you have signed in.

  • Announcements

    • Dries007

      ATTENTION Forum Database Breach   03/04/2019

      There has been a breach of our database. Please make sure you change your password (use a password manager, like Lastpass).
      If you used this password anywhere else, change that too! The passwords themselves are stored hashed, but may old accounts still had old, insecure (by today's standards) hashes from back when they where created. This means they can be "cracked" more easily. Other leaked information includes: email, IP, account name.
      I'm trying my best to find out more and keep everyone up to date. Discord (http://invite.gg/TerraFirmaCraft) is the best option for up to date news and questions. I'm sorry for this, but the damage has been done. All I can do is try to make sure it doesn't happen again.
    • Claycorp

      This forum is now READ ONLY!   01/20/2020

      As of this post and forever into the future this forum has been put into READ ONLY MODE. There will be no new posts! A replacement is coming SoonTM . If you wish to stay up-to-date on whats going on or post your content. Please use the Discord or Sub-Reddit until the new forums are running.

      Any questions or comments can be directed to Claycorp on either platform.
pgelinas

[Solved] Crop growth on years 192 or longer is incorrect.

4 posts in this topic

Have you read, understood, and followed all of the rules listed in large text at the top of the support forum? (Yes/No): Yes

 

Answering "no" to the above question will result in your post being deleted.

 

TFC Version #: 79.21 Forge Version #: 10.13.4.1448 Please note that an actual number must be provided for both of the above fields.Simply saying "current" or "latest" will result in your post being locked, due to the fact that in a large number of cases, users who say they are using the "latest" or "current" version are actually using an outdated version. SSP/SMP (SinglePlayer/MultiPlayer): Both Description: Crop growth doesn't scale properly with the year length. On longer year, like 192, it's basically impossible to harvest anything that is planted the first year if you are not in a tropical zone. See https://github.com/Deadrik/TFCraft/pull/786 for fix and explanation on the cause. Have you deleted your config files or are using default configs and are still able to reproduce this bug? (Yes/No): Modified config for longer year length. If you answered no to the above question, delete all 3 TFC config files (TFCCrafting, TFCOptions, TFCOre), do NOT edit or add to any of the files, and try to reproduce the bug.This question is here because many bugs are caused by mistakes in config files. If you are unable to delete your edited config files, please provide a list of the config options you have changed. Do you have any mods other than Forge and TFC installed? (Yes/No):  NoIf yes, which mods?  If you have Optifine or Cauldron installed, can you still reproduce the bug after uninstalling them? (Yes/No):  If you answered no to the above question, uninstall Optifine/Cauldron and try to reproduce the bug.Both Optifine and Cauldron edit the base classes of forge that TFC uses. Because of this, we cannot officially support any issues that happen only when these mods are installed. In the majority of cases, TFC is not causing the bug; Optifine/Cauldron is and TFC can do nothing to fix it.All bug reports should have an answer of "Yes" to this question.If you refuse to uninstall Optifine/Cauldron, and cannot reproduce the bug when the mods are not installed, do not bother making a bug report, as it will be locked and ignored. Pastebin.com link of the Crash Report:

0

Share this post


Link to post
Share on other sites

There was a much simpler fix than the one suggested in the PR.

 

Here's a spreadsheet showing best-case growth times for crops after the simple fix was applied:

 

https://www.dropbox.com/s/kd447mxwaa45nig/Crop%20Analysis.xlsx?dl=0

 

It shows year length, days to reach maturity, the growth value it got to when it hit maturity, the nutrient and fertilizer levels remaining after the crop has finished growing, as well as ratio comparisons against the default 96 days. The data is there for every crop for all valid year lengths between 96 and 720.

0

Share this post


Link to post
Share on other sites

There was a much simpler fix than the one suggested in the PR.

 

Here's a spreadsheet showing best-case growth times for crops after the simple fix was applied:

 

https://www.dropbox.com/s/kd447mxwaa45nig/Crop%20Analysis.xlsx?dl=0

 

It shows year length, days to reach maturity, the growth value it got to when it hit maturity, the nutrient and fertilizer levels remaining after the crop has finished growing, as well as ratio comparisons against the default 96 days. The data is there for every crop for all valid year lengths between 96 and 720.

 

but shouldn't the Grow-ratio and the Time-ratio be similar (last 2 columns)? Like if the year is 3 times the standard time, the mature time should also be 3 times the standard one.

 

Let's take a look at Wheat, if I correctly understood the table:

  • it needs 10 days of a 96 days long year = about 10% of the year = just a bit more than one month;
  • it needs 330 days if the year is 660 days long = 50% = 6 months.

I would expect it always being around 10% of the whole year (or between 1 and 2 months)...

 

(I think the timeMultiplier should be removed at all from the formula, since timeRatio96 is already being used for year length compensation)

Edited by CHeuberger
0

Share this post


Link to post
Share on other sites

No. It is intentional that they grow ratio and the time ratio are not the same. In reality, any year length under 360 you are getting a growth time less than what was chosen for balance. The number of days required to grow a crop in the 360 year length is based off of how long those crops take to grow in real life. With a shorter year length, the crops grow even faster than that for balance reasons.

0

Share this post


Link to post
Share on other sites