Content: Slate Blackcurrant Watermelon Strawberry Orange Banana Apple Emerald Chocolate Marble
Background: Slate Blackcurrant Watermelon Strawberry Orange Banana Apple Emerald Chocolate Marble
Pattern: Blank Waves Notes Sharp Wood Rockface Leather Honey Vertical Triangles
Welcome to TerraFirmaCraft Forums

Register now to gain access to all of our features. Once registered and logged in, you will be able to contribute to this site by submitting your own content or replying to existing content. You'll be able to customize your profile, receive reputation points as a reward for submitting content, while also communicating with other members via your own private inbox, plus much more! This message will be removed once you have signed in.

  • Announcements

    • Dries007

      Server Move   09/13/2018

      I (Dries007) have recently taken over as main developer and server admin. This involved moving servers to reduce cost. It's likely there will be some more downtime in the future but most  things should be sorted by now. This forum is in dire need of replacement as the software is quite old and can't be easily updated. If you wish to discuss or stay updated, join our discord: https://invite.gg/terrafirmacraft. The forum will remain available to read, but will be locked in the future, when a new system is setup. The forum and wiki are now ad free. If you'd like to contribute to keeping it that way, you can do so via paypal or patreon.
    • Dries007

      ATTENTION Forum Database Breach   03/04/2019

      There has been a breach of our database. Please make sure you change your password (use a password manager, like Lastpass).
      If you used this password anywhere else, change that too! The passwords themselves are stored hashed, but may old accounts still had old, insecure (by today's standards) hashes from back when they where created. This means they can be "cracked" more easily. Other leaked information includes: email, IP, account name.
      I'm trying my best to find out more and keep everyone up to date. Discord (http://invite.gg/TerraFirmaCraft) is the best option for up to date news and questions. I'm sorry for this, but the damage has been done. All I can do is try to make sure it doesn't happen again.
Bunsan

[Can't Reproduce] Master Prospector and Coal Bug

5 posts in this topic

Keep forgetting to report this. If a player has master level prospecting then the message for coal veins is broken because they don't have a quality. 

0

Share this post


Link to post
Share on other sites

Could you be more specific? Does the message not appear at all, is there some sort of unlocalized text in the message? IIRC, at master level all it does is simulate breaking the block with a pickaxe and returns the name of the item it would drop. There's no special quality checking being done.

0

Share this post


Link to post
Share on other sites

It gives the unlocalized name.

 

in ItemProPick line 84

 
if (block == TFCBlocks.ore && rank == SkillRank.Master)												 													meta = ((BlockOre) block).getOreGrade(te, meta);

Line 88

 
tellResult(player, new ItemStack(TFCItems.oreChunk, 1, meta));

 

Edited by Bunsan
0

Share this post


Link to post
Share on other sites

I can't reproduce this. And even if the issue was with the whole ore grade thing, it still wouldn't display the unlocalised name. getOreGrade adds either 35 or 49 to the meta. Coal is meta 14 and 15, so that means it would either give you a reading of poor native copper or poor native gold. It could maybe give you a reading for item.Ore.name if the tile entity had a quality value of 2 stored on it, but coal ore blocks don't have quality values stored on their tile entities. In fact, if you put a breakpoint in getOreGrade and then use the propick next to or on a coal vein, it shows that the quality value on the tile entity & 7 is 0, and it simply returns the same number you originally passed it.

0

Share this post


Link to post
Share on other sites

I just ran into the item.Ore.name error and this post was the only result Google turned up.  After doing a little digging, I was able to confirm Bunsan's findings.  I just recently hit master on the ProPick and now coal is throwing the error he described.  Screenshots below.

 

2016-10-10_18.25.05.jpg

2016-10-10_18.24.02.jpg

0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now